[APP-14984] - Fix resolvedSchemas.json adding required fields #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzolo22
approved these changes
Apr 8, 2024
eyadmba
approved these changes
Apr 8, 2024
|
|
||
| for SCHEMA_FILENAME in $(ls src/schemas | sort); do | ||
| SCHEMA=$(echo $SCHEMA_FILENAME | cut -d . -f 1) | ||
| sed -i "" "\|$MARKER|a\\ | ||
| sed -i"" "\|$MARKER|a\\ |
There was a problem hiding this comment.
Suggested change
| sed -i"" "\|$MARKER|a\\ | |
| sed -i "" "\|$MARKER|a\\ |
There was a problem hiding this comment.
This is a fix to make it work equal on linux and macos. The previous code just worked on mac.
| } | ||
| /** | ||
| * sortObject sorts an objects and returns an object with keys in alphabetical | ||
| * order | ||
| * @param { Object } obj | ||
| * @returns an object with the keys in sorted alphabetical order | ||
| */ | ||
| function sortObject(obj) { | ||
| function sortObject<T extends Record<string, unknown>>(obj: T) { |
There was a problem hiding this comment.
Does this need to be generic?
Would this not work?
Suggested change
| function sortObject<T extends Record<string, unknown>>(obj: T) { | |
| function sortObject(obj: Record<string, unknown>) { |
There was a problem hiding this comment.
The type need to be generic so the type returned is the same type passed to the function. In your suggestion the returned type will be Record<string, unknown>.
| @@ -7,7 +7,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| node-version: [14.x] | |||
| node-version: [18.x] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.