Adds error handling in networkRequest #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the requets fails randomly and/or the content type is not json. The lack of error handling makes consumers unable to catch the error to see what went wrong. This commit adds error handling for both cases when the request fails (status !== 2xx) and when the content-type is not json.
zemberdotnet
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Thank you for your contribution @lodi-g. If you're ready I can merge this.
|
Please go ahead and merge. Thanks!
Sent from [Proton Mail](https://proton.me/mail/home) for iOS
…On Thu, Oct 26, 2023 at 21:21, Matthew Zember ***@***.***(mailto:On Thu, Oct 26, 2023 at 21:21, Matthew Zember <<a href=)> wrote:
@zemberdotnet approved this pull request.
Thank you for your contribution ***@***.***(https://github.com/lodi-g). If you're ready I can merge this.
—
Reply to this email directly, [view it on GitHub](#154 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ABCRWL2RWOHIKOMTCEANALTYBKZ2ZAVCNFSM6AAAAAA6RU4OHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBQGQ4DSOBYGY).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the requets fails randomly and/or the content type is not json. The lack of error handling makes consumers unable to catch the error to see what went wrong.
This commit adds error handling for both cases when the request fails (status !== 2xx) and when the content-type is not json.
I'd recommend to test it on your side as well because the behavior of the backend is not entirely known by me.