Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding abort & publish events methods for jobs #156

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

SrdjanCosicPrica
Copy link
Contributor

Hi

I'm adding 2 methods in this PR.

  • abortSyncJob
  • publishEvents

When using the node client for custom integrations, it's useful to abort the job in case of failure and see that in the J1 UI.
Same goes for Publish Events where it is nice that we can see our own useful logs for our custom integrations in case they fail for example.

Adding 2 small fixes as well.

  • Export of FetchError class. This allows one to do if (err instanceof FetchError) and handle the error more gracefully. Root reason is that the error message is so long that when it gets sent to Sentry, a big part of it is truncated and there is no other way to see the other attributes. Adding these attributes allows TypeScript to access them without having to do @ts-ignore.
  • Move eslint-config-prettier to devDependencies. No reason to have that in production dependencies

@SrdjanCosicPrica SrdjanCosicPrica requested a review from a team as a code owner February 13, 2024 12:55
@SrdjanCosicPrica
Copy link
Contributor Author

Hi @xdumaine
Thank for the approval.
What else needs to be done?

All I see is

JupiterOne/integrations was requested for review as a code owner

as pending reviewer

@xdumaine xdumaine merged commit 2d69c64 into JupiterOne:main Feb 15, 2024
4 checks passed
@xdumaine
Copy link
Contributor

@SrdjanCosicPrica this has been released in 1.1.0, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants