Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace skip limit pagination with cursor #162

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Replace skip limit pagination with cursor #162

merged 2 commits into from
Jul 23, 2024

Conversation

chrichts
Copy link
Contributor

  • Changed the way the sdk does pagination to the proper method of using a cursor, the current implementation was resulting in duplicate entities and is a known artifact of the neo4j upgrade
  • Add the use of variable result size
  • Add a progress bar
  • Did some other minor cleanup

@chrichts chrichts requested a review from a team as a code owner July 23, 2024 09:54
@socket-security Socket Security
Copy link

socket-security bot commented Jul 23, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 62.2 kB andidittrich

View full report↗︎

Gonzalo-Avalos-Ribas
Gonzalo-Avalos-Ribas previously approved these changes Jul 23, 2024
View reviewed changes
Copy link

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrichts chrichts merged commit 5168178 into main Jul 23, 2024
9 checks passed
@chrichts chrichts deleted the NO-TICKET-fix-sdk-to-use-proper-pagination branch July 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrichts @Gonzalo-Avalos-Ribas