SRE-474 - Add risk for each unsigned commit #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain versions of typescript, when used with the ttypescript wrapper, appear to be sensitive to node version changes.
The failing behavior is an error of the form:
```
$ yarn ttsc -p tsconfig-dist.json
$ /opt/jupiterone/node_modules/.bin/ttsc -p tsconfig-dist.json
/opt/jupiterone/node_modules/ttypescript/lib/loadTypescript.js:29
var _e = ts.versionMajorMinor.split('.'), major = _e[0], minor = _e[1];
^
TypeError: Cannot read properties of undefined (reading 'split')
at Object.loadTypeScript (/opt/jupiterone/node_modules/ttypescript/lib/loadTypescript.js:29:35)
```
This occurs with Typescript 4.3.1 and the latest point releases of node 12, 14, and 18. Node 14.20.1 works as expected. CI started failing when GitHub changed the point release of the `12.x` version spec under the hood. This change pins to a known-working version in GHA and docker.
Upgrading @jupiterone/typescript-tools was considered but will require changing basically all of the dev dependencies and it is unclear whether the `.d.ts` files provided by several of the prod dependencies (oclif, etc) are compatible with the newer `ttsc`.
erichs
force-pushed
the
SRE-474-verify-commits
branch
from
83e62aa to
7bdcbcc
Compare
behobu
approved these changes
Mar 2, 2023
| WORKDIR /opt/jupiterone | ||
| COPY . . | ||
| RUN yarn install && yarn build | ||
|
|
||
| FROM node:14-alpine | ||
| FROM node:14.20.1-alpine |
There was a problem hiding this comment.
I thought we were moving away from alpine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this will add 1 point of risk for every unsigned commit found in PR scope. This value can be adjusted as needed over the course of the SLSA3: Verified History initiative to reflect updated risk valuations.