Skip to content

Commit

Permalink
fix: print full error on a killed deployment
Browse files Browse the repository at this point in the history
  • Loading branch information
Justintime50 committed Jun 3, 2024
1 parent 2630bad commit 52a30f3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Adds a healthcheck to the nginx Docker container
- Prints deployment log to the error logger if `log_level` is set to `DEBUG`
- Raises a `HarveyError` on deployment fail instead of `sys.exit(1)`, removes redundant `sys.exit(0)` on success
- Prints complete error instead of unhelpful "deployment failed" message
- Captures Slack errors via Sentry but no longer raises an exception to ensure builds continue even if there is a problem with message delivery

## v1.0.3 (2023-10-25)
Expand Down
2 changes: 1 addition & 1 deletion harvey/utils/deployments.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def kill_deployment(message: str, webhook: Dict[str, Any]):
if Config.use_slack:
Message.send_slack_message(error_message)

raise HarveyError(error_message)
raise HarveyError(deployment_logs)


def succeed_deployment(message: str, webhook: Dict[str, Any]):
Expand Down

0 comments on commit 52a30f3

Please sign in to comment.