chore: raise HarveyError for failed deploys, no redundant exit on suc…

…cess

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Adds support for Python 3.12
 - Prints deployment log to the error logger if `log_level` is set to `DEBUG`
+- Raises a `HarveyError` on deployment fail instead of `sys.exit(1)`, removes redundant `sys.exit(0)` on success
 
 ## v1.0.3 (2023-10-25)
 

harvey/utils/deployments.py

@@ -1,4 +1,3 @@
-import sys
 from typing import (
     Any,
     Dict,
@@ -7,6 +6,7 @@
 import woodchips
 
 from harvey.config import Config
+from harvey.errors import HarveyError
 from harvey.messages import Message
 from harvey.repos.deployments import store_deployment_details
 from harvey.repos.locks import (
@@ -37,7 +37,7 @@ def kill_deployment(message: str, webhook: Dict[str, Any]):
     if Config.use_slack:
         Message.send_slack_message(error_message)
 
-    sys.exit(1)
+    HarveyError(error_message)
 
 
 def succeed_deployment(message: str, webhook: Dict[str, Any]):
@@ -55,8 +55,6 @@ def succeed_deployment(message: str, webhook: Dict[str, Any]):
     if Config.use_slack:
         Message.send_slack_message(success_message)
 
-    sys.exit(0)
-
 
 def _strip_emojis_from_logs(output: str) -> str:
     """Replace the emojis for logs since they won't render properly there."""