Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Android compile SDK to 35 #449

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Bump Android compile SDK to 35 #449

merged 2 commits into from
Jan 24, 2025

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jan 18, 2025

No description provided.

@twyatt twyatt added patch Changes that should bump the PATCH version number android labels Jan 18, 2025
@twyatt twyatt requested review from cedrickcooke and a team as code owners January 18, 2025 00:00
@twyatt twyatt requested a review from davertay-j January 18, 2025 00:00
@twyatt twyatt enabled auto-merge (squash) January 18, 2025 00:01
@twyatt
Copy link
Member Author

twyatt commented Jan 18, 2025

> Task :hierarchy:compileKotlinIosSimulatorArm64

e: element-view/src/androidMain/kotlin/BitmapPool.kt:25:100 Argument type mismatch:
    actual type is 'android.graphics.Bitmap.Config?',
               but 'android.graphics.Bitmap.Config' was expected.

> Task :element-view:compileReleaseKotlinAndroid FAILED

@cedrickcooke cedrickcooke self-assigned this Jan 24, 2025
Copy link

Test Results

 62 files  ±0   62 suites  ±0   10s ⏱️ -11s
321 tests ±0  321 ✅ ±0  0 💤 ±0  0 ❌ ±0 
366 runs  ±0  366 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 98efecf. ± Comparison against base commit 6bb63b4.

This pull request removes 69 and adds 69 tests. Note that renamed tests count towards both.
com.juul.krayon.color.ColorTests ‑ checkArgbTransformIsCorrect[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkComponentRetrievalIsCorrect[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkComponentsAreMasked[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkCopyWorks[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withFloatInput_matchesIntegerInput[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withLargeFloatInput_throwsException[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withNegativeFloatInput_throwsException[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ toHexString_withNoTransparency_omitsAlpha[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ toHexString_withTransparency_includesAlpha[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
com.juul.krayon.color.OperationsTests ‑ lerp_fromWhiteToBlack_isGray[js, browser, ChromeHeadless131.0.0.0, MacOS10.15.7]
…
com.juul.krayon.color.ColorTests ‑ checkArgbTransformIsCorrect[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkComponentRetrievalIsCorrect[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkComponentsAreMasked[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkCopyWorks[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withFloatInput_matchesIntegerInput[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withLargeFloatInput_throwsException[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withNegativeFloatInput_throwsException[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ toHexString_withNoTransparency_omitsAlpha[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ toHexString_withTransparency_includesAlpha[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
com.juul.krayon.color.OperationsTests ‑ lerp_fromWhiteToBlack_isGray[js, browser, ChromeHeadless132.0.0.0, MacOS10.15.7]
…

@twyatt twyatt merged commit 449a1a0 into main Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android patch Changes that should bump the PATCH version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants