Pass the Executor instance to operators #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainmckay
changed the title
|
Could I get some feedback on this? |
|
Ping |
iainmckay
force-pushed
the
pass-executor-to-operator
branch
from
dcbbf2d to
df81034
Compare
… it's __invoke method
iainmckay
force-pushed
the
pass-executor-to-operator
branch
from
df81034 to
3374261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a couple of instances where we need extra information in our operators and the ability to manipulate the parameters (add/remove placeholders in the case of SQL operators). We've accomplished this by using a custom trait but as it is right now, we cannot access anything outside of the operator.
This PR passes the instance of the Executor to the operator as the last parameter, as such this should be BC as existing operators will simply ignore it.