Prepend monobehaviour base fields to generated typetrees #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of relying on generator to do it
isHarryh
approved these changes
Jul 12, 2025
K0lb3
reviewed
Aug 1, 2025
| @@ -60,6 +60,7 @@ def get_nodes_up(self, assembly: str, fullname: str) -> TypeTreeNode: | |||
| 0, | |||
| 0, | |||
| m_MetaFlag=base_root.m_MetaFlag, | |||
| m_Children=base_node.m_Children[:], | |||
There was a problem hiding this comment.
Hard to say if a copy is really necessary.
|
I will merge this PR today or tomorrow, after I push the generator update as new version, so that the changes here include the updated generator version as minimal dependency version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary PR to UnityPy-Org/TypeTreeGeneratorAPI#4
This should make all backends usable, whereas previously only the
AssetStudiobackend would include monobehaviour base fields.Now, the generator generates only the script fields, and
UnityPyprepends the fields.Needs a version bump of the generator when that is released.