-
-
Notifications
You must be signed in to change notification settings - Fork 150
Refactor MeshHelper #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor MeshHelper #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0lb3
reviewed
Aug 1, 2025
K0lb3
reviewed
Aug 1, 2025
K0lb3
requested changes
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
K0lb3
reviewed
Aug 1, 2025
K0lb3
reviewed
Aug 1, 2025
Quite good points! All resolved. In order to solve type issues and make the code more readable, I had changed the triangle list-assign to list-append, but making it ~5% slower, very stupid haha. Now reverted to list-assign style. |
K0lb3
previously approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does some improvements to MeshHelper.
flat_list_to_tuples
an inline function.lists_to_tuples
function to fix the type error thatList[List]
produced by thezeros
function cannot be assigned to tuple-member-lists such asList[Tuple3f]
List[Tuple4f]
.get_triangles
function.indexCount
fix for TriangleStrip submeshes, see AssetStudio's code.get_triangles
function (I have tested that using NumPyas_strided
function cannot realize a speed-up).