Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two CMake uninitialized-variable warnings #908

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jan 7, 2024

  • Ensure GAMMARAY_PROBE_ABI_POSTFIX is always set, even if it's empty.
  • Use QT_VERSION_MAJOR in plugins/qmlsupport instead of QT_MAJOR_VERSION, to match rest of the CMake code.

@dantti
Copy link
Member

dantti commented Jan 7, 2024

Since we now require Qt 5.15 we could instead just use versionless targets

@winterz
Copy link
Contributor

winterz commented Jan 8, 2024

I'm merging this as it is a proper fix.
we can change to versionless if we want in a new PR

@winterz winterz merged commit ac8ed0c into KDAB:master Jan 8, 2024
12 checks passed
@ferdnyc ferdnyc deleted the cmake-warns branch January 14, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants