CMake: Split Library and Plugin types into PROBE and UI; support BUILD_SHARED_LIBS #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Kentzo
force-pushed
the
fix-lib-type
branch
9 times, most recently
from
ebfff5a to
02a4241
Compare
…D_SHARED_LIBS User's choice of what's to be built is disambiguated from how it's built. Both static and shared builds of both library and plugins is now supported.
|
WIP and open for discussion. |
|
The idea was to allow static probes alongside non-static UI. To achieve this pretty much every library needs to be split into static and shared versions with actual build path determined by config variables. That's doable, but probably too much effort when what's needed is just two variants of the project:
For [2] some modifications are still necessary to make sure that static probe libraries carries all dependencies in itself. |
|
Closed in favor of #936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User's choice of what's to be built is disambiguated from how it's built. Both static and shared builds of both library and plugins is now supported.