CMake: Explicitly handle incompatible option overrides #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Kentzo
force-pushed
the
warn-overrides
branch
from
2e57765
to
4bd3830
Compare
|
The goal here is to have explicit errors when user sets options to conflicting values. |
Kentzo
force-pushed
the
warn-overrides
branch
from
4bd3830
to
fe8072c
Compare
Provide sensible defaults for the *ONLY* builds and explicitly verify incompatible configurations.
Kentzo
force-pushed
the
warn-overrides
branch
from
3faa454
to
639b99e
Compare
|
Test failure seems to be unrelated to the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide sensible defaults for the ONLY builds and explicitly verify incompatible configurations.