Add more signals to cxx_qt_lib #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BenFordTytherington
commented
Mar 7, 2025
BenFordTytherington
commented
- Add objectCreated signal to QQmlApplicationEngine
- Add objectCreationFailed signal to QQmlApplicationEngine
- Fixed bug where type_name doesn't recognise QObject
- Fixed qualification of QCoreApplication in bridge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12593 12594 +1
=========================================
+ Hits 12593 12594 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenFordTytherington
force-pushed
the
improve-signals-in-qapps
branch
2 times, most recently
from
11b5572 to
29d3a8c
Compare
ahayzen-kdab
reviewed
Mar 7, 2025
ahayzen-kdab
reviewed
Mar 7, 2025
BenFordTytherington
force-pushed
the
improve-signals-in-qapps
branch
11 times, most recently
from
2161557 to
6a278c1
Compare
|
Working on a CXX fix which should help with the CI issues. |
Closed
So looks like #1222 has helped CI (only issue is around the MSRV now as versions have changed) using the patched CXX, so i'll try submitting that upstream. |
BenFordTytherington
force-pushed
the
improve-signals-in-qapps
branch
from
6a278c1 to
ab73da3
Compare
BenFordTytherington
force-pushed
the
improve-signals-in-qapps
branch
from
ab73da3 to
4828e6d
Compare
BenFordTytherington
force-pushed
the
improve-signals-in-qapps
branch
2 times, most recently
from
353014a to
e4cbaba
Compare
- Add objectCreated signal to QQmlApplicationEngine - Add objectCreationFailed signal to QQmlApplicationEngine - Fixed bug where type_name doesn't recognise QObject - Fixed qualification of QCoreApplication in bridge
BenFordTytherington
force-pushed
the
improve-signals-in-qapps
branch
from
e4cbaba to
c165d7d
Compare
ahayzen-kdab
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.