-
Notifications
You must be signed in to change notification settings - Fork 83
cxx-qt-build: return an Interface from CxxQtBuilder #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LeonMatthesKDAB
wants to merge
10
commits into
KDAB:main
Choose a base branch
from
LeonMatthesKDAB:1125-build-system-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
cxx-qt-build: return an Interface from CxxQtBuilder #1285
LeonMatthesKDAB
wants to merge
10
commits into
KDAB:main
from
LeonMatthesKDAB:1125-build-system-changes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs more refactoring later but is a first step.
This allows export() to have no args meaning we can return an Interface from the compile command next.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1285 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 12772 12780 +8
=========================================
+ Hits 12772 12780 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f6b1fe6
to
45162f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an Interface from the CxxQtBuilder.
This is a rebased version of the original #1224 by @ahayzen-kdab