Skip to content

cxx-qt-build: return an Interface from CxxQtBuilder #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

LeonMatthesKDAB
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB commented May 22, 2025

Return an Interface from the CxxQtBuilder.

This is a rebased version of the original #1224 by @ahayzen-kdab

  • cxx-qt-build: split interface into a separate file
  • cxx-qt-build: move write_manifest to export of Interface
  • cxx-qt-build: move write of exported include directories to interface
  • cxx-qt-build: store manifest and dependencies in Interface for now
  • cxx-qt-build: return an Interface rather than taking as input
  • cxx-qt-build: check the links key when exporting
  • cxx-qt-build: split include and exported include dirs
  • cxx-qt-build: include headers automatically like CXX
  • cxx-qt-build: remove CxxQtBuilder::library instead use new and export

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4979207) to head (45162f0).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1285   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines        12772     12780    +8     
=========================================
+ Hits         12772     12780    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants