Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash if samples have different amount of costs associated #636

Merged
merged 2 commits into from
May 23, 2024
Merged

fix: crash if samples have different amount of costs associated #636

merged 2 commits into from
May 23, 2024

Commits on May 17, 2024

  1. fix: add a wrapper for std::valarray to catch out of range access 

    If we have a recording with the following layout: A B C where A: part
where function f is accessed
B: lost samples
C: part where function g is accessed
then f won't have the lost events cost while g does. This will cause a
crash when the model tries to access it.

This patch replaces the typedef ItemCost with a real wrapper that will
catch the out range access.

fixes: #629
    @lievenhey
    lievenhey committed May 17, 2024
    Configuration menu
    Copy the full SHA
    58fba35 View commit details
    Browse the repository at this point in the history

  2. chore: update clang-format

    @lievenhey
    lievenhey committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3b4e1a6 View commit details
    Browse the repository at this point in the history