-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update, mostly for AppImage notes #639
Conversation
we are now using conventional commits. Please prefix your commit message with |
Wouldn't docs be more appropriate? |
Sure, its just that the conventional commits documentation is weird (at least what I found) so I am not sure which tags actually exists. I knew of fix, feat, chore, test and ci. |
00635bb
to
09b0a4d
Compare
* add license information * add conventional commits convention
Added a second commit for the conventional commits (I've totally missed that) in CONTRIBUTING.md and also updated the HACKING file. Note that Markdownlint is wrong - dropping the double whitespace will lead to the text being all on one line (the formatting rule was always two spaces and a line break means a line break). Should we still pull this or use "one long rendered line" or "adding a paraghraph for each sentence? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the changes to the version + sha? that's just an example
I wanted to use a newer version and date as this makes the document look less outdated to me. If you want to I'll only update the 1.3 one to the 1.4 (to make samples use the same) and don't change the date.
Am 17. Mai 2024 09:44:09 MESZ schrieb Milian Wolff ***@***.***>:
…
@milianw commented on this pull request.
why the changes to the version + sha? that's just an example
> $ tar -xvf hotspot-debuginfo-*.tar.bz2
-hotspot-debuginfo-v1.4.0-43-g02fd82c/usr/bin/hotspot
-hotspot-debuginfo-v1.4.0-43-g02fd82c/usr/lib64/libexec/hotspot-perfparser
+hotspot-debuginfo-v1.5.0-17-g0ed41cf/usr/bin/hotspot
here and below. unrelated changes?
--
Reply to this email directly or view it on GitHub:
#639 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
@GitMensch can you rebase this patch please. Master contains a patch that should stop |
README.md: * updated AppImage notes - point to latest/continuous release instead of CI artifacts * case adjustments for Hotspot and AppImage * http -> https * some minor rewording HACKING.md: * drop the unzip step as it is not needed any more * replace shown version string by a clear pseudo-version * update shown dates to a more current one
Done. To care for @milianw's comments I've also used the previous SHA in the version numbers referenced (less changes) and changed the version number itself top a clear pseudo-version so it won't be likely for any one to feel the need to update them. |
CONTRIBUTING.md:
README.md:
HACKING.md: