Update readme #650
Merged
Update readme #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
GitMensch
reviewed
May 29, 2024
|
Possibly missing: hint at the 'new' "go to" command via context menu if there is not a totally clean way to reach it that I've missed. Do I misremember that the arrows were drawn as lines instead of ascii? |
|
Possibly add to the command line options as well after merging #653. |
That is a feature that @milianw added some time ago |
lievenhey
force-pushed
the
update-readme
branch
2 times, most recently
from
94c1744
to
0d4d6de
Compare
GitMensch
suggested changes
Jun 4, 2024
There was a problem hiding this comment.
English messages - then fine to merge.
Thank you for updating the screenshots to have the nice lines in as well.
Concerning the flamegraph - maybe some of the perf.data testfiles in the repo look "more interesting" while still showing the darker (inlined) frames?
|
🤦 |
milianw
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.