-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/query dsl 도입 및 적용하기 #433
base: develop
Are you sure you want to change the base?
The head ref may contain hidden characters: "feature/query_dsl_\uC801\uC6A9"
Conversation
- build.gradle.kts에 query dsl 관련 설정 추가
JPA Factory를 bean 등록하기 위함
spring data jap custom repository 방식 사용
page nation 처리해야 하는 부분은 제외
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리팩토링 수고하셨습니다~~!
|
||
private final JPAQueryFactory jpaQueryFactory; | ||
|
||
@Modifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 어노테이션은 어떤 역할을 하나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조회를 제외한 쿼리를 직접 작성할 경우에 붙여줘야 하는 걸로 압니다! (맞나용?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!!! QueryDSL 드디어 적용... ㅎㅎ👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gradlew, gradlew.bat 파일들이 올라갔는데 의도하신 건지 궁금합니당!
|
||
private final JPAQueryFactory jpaQueryFactory; | ||
|
||
@Modifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조회를 제외한 쿼리를 직접 작성할 경우에 붙여줘야 하는 걸로 압니다! (맞나용?)
🔥 Related Issue
📝 Description
Query DSL을 적용하기 위한 설정을 추가했습니다.
일부 Repository의 문자열로 된 query를 Query DSL로 변경하는 작업을 하였습니다.
모든 Repository를 다 변경한 것이 아니라서, 관심 있으신 분들 이어 받아서 작업하시면 될 것 같습니다!
⭐️ Review Request
쿼리를 맞게 수정했는지 꼼꼼하게 확인 부탁드립니다!
쿼리 테스트를 어떻게 하는게 좋을지 고민을 많이 해봤는데, 아직 경험이 없어 잘 모르겠습니다! 추천이나 조언 환영합니다 😄
혹시라도 작동이 안되거나 이 부분이 좀 이상하다!! 싶으면 언제든지 말씀해주세요~!