Harry #8
Open
Harry #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DB까지 다 연결시켜버리는 해리 클라스... |
minkukjo
commented
Aug 25, 2020
| ) { | ||
|
|
||
| @PostMapping | ||
| fun createBoard(@RequestBody boardRequest: BoardRequest, @RequestParam name:String):String { |
There was a problem hiding this comment.
컨트롤러에서 모든 로직을 처리하는 것은 아름답지 않네요
Service 쪽으로 로직을 옮기는게 맞는 것 같습니다
DongHyukki
reviewed
Aug 25, 2020
|
|
||
| class UserJoinRequest ( | ||
| @JsonProperty("name") | ||
| val name: String |
There was a problem hiding this comment.
프로젝트소스에서도 이런거를 많이봤는데 변수 이름이 같은데 @JsonProperty("name")
를 어노테이션 하는거는 코딩 스타일 인가요? 궁금!
There was a problem hiding this comment.
@DongHyukki 넹 스타일의 차이인 것 같습니다. 나중에 프로퍼티 이름이 변경되더라도 Request key가 같아야하는 경우가 있을 수도 있다고 생각해서 저는 다 달아주는 편이에요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.