Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild tests #9

Open
3 of 4 tasks
mmaelicke opened this issue Oct 21, 2021 · 6 comments
Open
3 of 4 tasks

Rebuild tests #9

mmaelicke opened this issue Oct 21, 2021 · 6 comments
Assignees
Labels

Comments

@mmaelicke
Copy link
Member

mmaelicke commented Oct 21, 2021

The old tests are a bit messy. We should change them all over:

  • move the tests folder to the top level
  • get rid of unittest and move to pytest
  • test against the working Matlab code
  • build a github action to run tests

@AlexDo1 do you want to take on this? Otherwise assign to me.

@AlexDo1
Copy link
Collaborator

AlexDo1 commented Oct 21, 2021

I emailed Uwe to see if we can meet tomorrow so he can give me some explanations about his Matlab code.

So I can do it. I'm also interested in trying out Github actions and some Matlab practice wouldn't be bad either.

@AlexDo1 AlexDo1 self-assigned this Oct 25, 2021
@AlexDo1
Copy link
Collaborator

AlexDo1 commented Oct 25, 2021

I am currently working on the tests.
What would you use as test data?
Some 'random' numpy data as in the current tests or should I use some data from metacatalog, for example?

@mmaelicke
Copy link
Member Author

I think for information theory it is perfectly fine to create random samples. In scipy and sklearn are also methods to create samples from joint probabilities and clustered data.

@AlexDo1
Copy link
Collaborator

AlexDo1 commented Oct 25, 2021

All right, I would then go by how you did it in the old test with np.random.seed and two distributions.
I would then use the two data sets shown here for testing:
Bildschirmfoto 2021-10-25 um 16 10 02

@mmaelicke
Copy link
Member Author

perfect.

@mmaelicke
Copy link
Member Author

You can save the data to txt and calculate test results with Uwe's code

@AlexDo1 AlexDo1 mentioned this issue Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants