Rebuild tests #10
Merged
Rebuild tests #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l info and cross entropy
Entropy of x is calculated with equal bins for x and y -> need to calculate probabilities before calling entropy(x)
no need to add 1e-15, nothing is calculated here, 1e-15 is added later in entropy() and cross_entropy()
mmaelicke
approved these changes
Oct 29, 2021
|
Cool, I will try to build a github action to run the tests now (#9). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rebuilt the tests using pytest and Uwe's Matlab code.
Currently the Matlab code is included in the test folder, but I don't know if we really want that. We should definitely talk to Uwe first if we want to have his Matlab code in the package.