Cost estimator #38
Merged
Cost estimator #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orzechow
force-pushed
the
change_dot_cluster_behavior
branch
from
b100b1b
to
063ae1e
Compare
orzechow
force-pushed
the
cost_estimator
branch
from
aa0e107
to
a57a458
Compare
|
Rebased on top of latest #36 |
orzechow
force-pushed
the
cost_estimator
branch
from
a57a458
to
0058060
Compare
orzechow
reviewed
Oct 4, 2024
|
Thanks! I like the cost definition. It's a understandable, but still a bit "sophisticated"👌 PS: I submitted the review a bit early, so not all comments are in the "review section" 🤷 |
ll-nick
commented
Oct 7, 2024
ll-nick
force-pushed
the
cost_estimator
branch
from
80e05f9
to
fb56e68
Compare
Merged
orzechow
approved these changes
Oct 7, 2024
Co-authored-by: Piotr Spieker <[email protected]>
The "relative Path" doesn't either so this should be more consistent.
ll-nick
force-pushed
the
cost_estimator
branch
from
fcdbe0a
to
e48d8ba
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more :-)
This one concerns #27
As discussed in person, the cost estimator estimates the cost using two metrics. A step/dot along the path to incentive short-term gains for following a path with many dots and a dot density metric for an area around the end of the path for long-term gains by moving to a promising are.
I did already add the eat dot behaviors into the respective cost arbitrator meaning that the tree should now be complete.