Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#83 #84

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Issue/#83 #84

merged 2 commits into from
Sep 5, 2024

Conversation

bayy1216
Copy link
Collaborator

@bayy1216 bayy1216 commented Sep 4, 2024

๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

  1. API ์ธ๊ฐ€์ž‘์—… - ๋ฏธ์ž‘์„ฑ ๊ตฌํ˜„
  2. ํ—ฌ์Šค์ฒดํฌ api - prefix๋กœ /api ์ถ”๊ฐ€ & ์ปจํ…Œ์ด๋„ˆ๋ฒˆํ˜ธ๋„ ์ถœ๋ ฅ

To Reviewers ๐Ÿ“ข

์‹œํ๋ฆฌํ‹ฐ ๊ณต์‹๋ฌธ์„œ๋ณด๊ณ  ์ฐธ๊ณ ํ–ˆ์Šต๋‹ˆ๋‹ค!

        return RoleHierarchyImpl.withDefaultRolePrefix()
                .role("ADMIN").implies("MANAGER")
                .role("MANAGER").implies("USER")
                .build();

role์—๋Š” "ROLE_"๋ฅผ ๋ถ™์ด๋ฉด ์•ˆ๋˜๊ณ  authority์—๋Š” "ROLE_"๋ฅผ ๋ถ™์—ฌ์•ผํ•˜๋„ค์š”

์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • ํ…Œ์ŠคํŠธ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ๋ฅผ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค.
  • API ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • API ํ˜ธ์ถœ์„ ์ง์ ‘ ์‹ค์‹œํ•˜์˜€๊ณ , ํ•ด๋‹น ๋ฐ์ดํ„ฐ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ์กด ์ฝ”๋“œ์— ์˜ํ–ฅ์„ ์ฃผ๋Š” ์ž‘์—… ๋‚ด์šฉ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • ํ–ฅํ›„ ์ถ”๊ฐ€์ ์ธ ์ž‘์—…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค.

โž• ๊ด€๋ จ ์ด์Šˆ

@bayy1216 bayy1216 self-assigned this Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Unit Test Results

28 testsโ€‚โ€ƒโ€ƒ28 โœ”๏ธโ€ƒโ€ƒ2s โฑ๏ธ
โŸโ€„8 suitesโ€ƒโ€ƒโŸโ€„0 ๐Ÿ’ค
โŸโ€„8 filesโ€„โ€‚โ€ƒโ€ƒโŸโ€„0 โŒ

Results for commit c537c6b.

@@ -19,6 +18,7 @@
@RequiredArgsConstructor
public class JwtProvider implements AuthenticationProvider {
private final JwtUtils jwtUtils;
private static final String ROLE_PREFIX = "ROLE_";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ฌ๋ฐ”๋ฅธ ์ปจ๋ฒค์…˜ ์ž˜๋ดค์Šต๋‹ˆ๋‹ค!

Copy link
Collaborator

@momnpa333 momnpa333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@kwonssshyeon kwonssshyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค !

@bayy1216 bayy1216 merged commit 6d30c8e into main Sep 5, 2024
3 checks passed
@bayy1216 bayy1216 deleted the issue/#83 branch September 5, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api ๊ถŒํ•œ ์„ค์ •
3 participants