Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

탭 너비 수정 #147 #158

Merged
merged 7 commits into from
Sep 28, 2024
Merged

탭 너비 수정 #147 #158

merged 7 commits into from
Sep 28, 2024

Conversation

joojjang
Copy link
Collaborator

PR

✨ 작업 내용

  • 탭 너비 수정 #147
  • tabs, tab-panels 폴더 분리하여 index.tsx로 관리
  • styles.ts 없애고 index.tsx로 통합
  • (tabs 컴포넌트가 사용된) challenge-record 페이지 리팩토링

✨ 참고 사항

  • 부모 요소의 스타일을 display: flex가 아닌 block으로 두면 tabs 너비가 부모 너비를 100% 채우게 되어 해결됩니다.
  • 부모 요소를 고치지 않고 tabs 내에서 flex-grow: 1로 두어 해결해보려 했으나... 속성이 안 먹더라고요
    @Dobbymin

⏰ 현재 버그


✏ Git Close

@joojjang joojjang added 😡 BugFix 버그 수정 ♻️ Refactoring 코드 리팩토링 및 모듈화 진행 labels Sep 28, 2024
@joojjang joojjang self-assigned this Sep 28, 2024
@joojjang joojjang changed the title Fix/tabs width #147 탭 너비 수정 #147 Sep 28, 2024
@joojjang joojjang merged commit 9999d64 into develop Sep 28, 2024
@joojjang joojjang deleted the Fix/tabs-width-#147 branch September 28, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😡 BugFix 버그 수정 ♻️ Refactoring 코드 리팩토링 및 모듈화 진행
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant