fix: Move .gdlintrc and update CodeStyleWorkflow.yml #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 11, 2024 21:22
Use simplifyed static analysis of the project -> https://github.com/Scony/godot-gdscript-toolkit/blob/master/action.yml Also workflow_dispatch to the workflow for better debugging This removes the auto commit which was a bad idea by me!
akien-mga
reviewed
May 11, 2024
logger.gd
Outdated
Comment on lines
480
to
486
| info( | ||
| ( | ||
| "The requested module '%s' does not exist. It will be created with default values." | ||
| % module | ||
| ), | ||
| PLUGIN_NAME | ||
| ) |
There was a problem hiding this comment.
IMO this kind of split doesn't really make things more readable. I'd argue it makes it worse.
Can we configure a higher max line length to avoid this wrappings?
There was a problem hiding this comment.
I've created an Issue Scony/godot-gdscript-toolkit#305
akien-mga
reviewed
May 11, 2024
added 2 commits
May 26, 2024 15:31
Command: `yq e -i '.' .github/workflows/CodeStyleWorkflow.yml -o=y´
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use simplifyed static analysis of the project -> https://github.com/Scony/godot-gdscript-toolkit/blob/master/action.yml Also workflow_dispatch to the workflow for better debugging
This removes the auto commit which was a bad idea by me!
Also adds a summary for the action:
