Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KPMP-4834_add-accordions-for-config-type #107

Merged
merged 253 commits into from
Apr 10, 2024
Merged

KPMP-4834_add-accordions-for-config-type #107

merged 253 commits into from
Apr 10, 2024

Conversation

Dert1129
Copy link
Contributor

@Dert1129 Dert1129 commented Apr 9, 2024

No description provided.

Dert1129 added 30 commits March 25, 2024 12:02
@Dert1129
log result.data
72ccbae
@Dert1129
loop through backend data and see what it looks like
55496d8
@Dert1129
do more loggign
a9036d9
@Dert1129
more logging
33c41e8
@Dert1129
define slides
185d7e4
@Dert1129
dispatch slides for each image type
2ba65da
@Dert1129
first pass at accordions
c7c510e
@Dert1129
update reactstrap for accordion
df39287
@Dert1129
upgrade common-components and pass accordion styles
9b145bc
@Dert1129
more accordion styles
ec1523c
@Dert1129
fix bootstrap
78630c4
@Dert1129
fix weird image sizes
bbb401d
@Dert1129
remove padding
d7a9d42
@Dert1129
remove height and font size
b0cf7b1
@Dert1129
remove padding
5231edc
@Dert1129
use default css for accordion
65b9532
@Dert1129
set padding for x and y to 0
06e4079
@Dert1129
use bootstrap variable
7deebff
@Dert1129
use correct accordion sass variable
b82572d
@Dert1129
change class names to adapt to bottstrap v5
ef70a1a
@Dert1129
Remove react column
fcdba1a
@Dert1129
put div inside of col
4f927a4
@Dert1129
write accordionList component
a594bea
@Dert1129
pass selected participant
1c78a50
@Dert1129
copy accordionList logic
0d2f4ad
@Dert1129
handle selected slide logic
d713eb5
@Dert1129
log selected participant
3a2c606
@Dert1129
remove unused props
ec56091
@Dert1129
pass setSelectedSlide to AccordionList
6137013
@Dert1129
also pass props to slideList
8164325
Dert1129 added 22 commits April 9, 2024 11:44
@Dert1129
switch up if statement
ef44147
@Dert1129
rever commits
4e0a79b
@Dert1129
check if accordion is already open and add it if it isn't
e3aafb8
@Dert1129
go back to older code
be87dba
@Dert1129
reverting a commit
1ac12e6
@Dert1129
Remove accordionId if header is clicked on and accordion is already open
3ae851a
@Dert1129
comment out code
a82e493
@Dert1129
log what's happening to openItems
3d1122c
@Dert1129
use different methods for using navigation arrows vs clicking on headers
deadc36
@Dert1129
do not pass accordion name to handleselectaccordion
4d91380
@Dert1129
fix weird bug
e6314c4
@Dert1129
log accordionIndex to see what's happening
a7f0d88
@Dert1129
use arrow notation to bind this to my method
4e5beb2
@Dert1129
remove handleSelectedAccordion from accordion header
66caf73
@Dert1129
comment out call to handleSelectAccordion from handleSelectSlide
8168b3f
@Dert1129
cleanup code and format code to look similar to the rest
198dff4
@Dert1129
general clean up of variables
b44c4db
@Dert1129
fix var naming convention
16828e0
@Dert1129
remove unused code
5da888b
@Dert1129
log openItems state and openAccordion
ebd0052
@Dert1129
copy code from handeNextSlide to handPreviousSlide
b2c8376
@Dert1129
remove duplicate code that's handled in toggle method
f084eb0
@rlreamy rlreamy merged commit fa4c7eb into develop Apr 10, 2024
1 check passed
@rlreamy rlreamy deleted the KPMP-4834_add-accordions-for-config-type branch April 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlreamy rlreamy rlreamy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dert1129 @rlreamy