#129 fix problem adding questions from question bank form

KQMATH · May 3, 2024 · 5ebb817 · 5ebb817
1 parent b38015a
commit 5ebb817
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 13 deletions.
diff --git a/amd/build/edit.min.js b/amd/build/edit.min.js
diff --git a/amd/build/edit.min.js.map b/amd/build/edit.min.js.map
diff --git a/amd/src/edit.js b/amd/src/edit.js
@@ -72,17 +72,20 @@ function offsetQuestion(questionId, offset) {
  * @param {number} courseModuleId
  */
 function listenAddToQuiz(courseModuleId) {
-    const addSelectedQuestionsButton = document.querySelector(selectors.edit.addSelectedQuestions);
-    addSelectedQuestionsButton.addEventListener('click', function() {
-        let questionIds = '';
-        for (const checkbox of document.querySelectorAll(selectors.edit.questionCheckedCheckbox)) {
-            questionIds += checkbox.getAttribute('name').slice(1) + ',';
+    document.addEventListener('click', event => {
+        const addSelectedQuestionsButton = event.target.closest(selectors.edit.addSelectedQuestions);
+        if (addSelectedQuestionsButton) {
+            event.preventDefault();
+            let questionIds = '';
+            for (const checkbox of document.querySelectorAll(selectors.edit.questionCheckedCheckbox)) {
+                questionIds += checkbox.getAttribute('name').slice(1) + ',';
+            }
+            $.post('edit.php', {
+                id: courseModuleId,
+                action: 'addquestion',
+                questionids: questionIds,
+            }, () => location.reload());
         }
-        $.post('edit.php', {
-            id: courseModuleId,
-            action: 'addquestion',
-            questionids: questionIds,
-        }, () => location.reload());
     });
 }
 

diff --git a/edit.php b/edit.php
@@ -89,7 +89,7 @@ function jazzquiz_edit_add_question(jazzquiz $jazzquiz, moodle_url $url): void {
     $questionids = required_param('questionids', PARAM_TEXT);
     $questionids = explode(',', $questionids);
     foreach ($questionids as $questionid) {
-        $jazzquiz->add_question($questionid);
+        $jazzquiz->add_question((int)$questionid);
     }
     // Ensure there is no action or questionid in the base url.
     $url->remove_params('action', 'questionids');