resolved issue with swapping of first- and lastname in csv export

KQMATH · Jun 26, 2023 · 6c21bbf · 6c21bbf
1 parent 630856c
commit 6c21bbf
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/classes/bank/jazzquiz_question_bank_view.php b/classes/bank/jazzquiz_question_bank_view.php
@@ -45,7 +45,8 @@ class jazzquiz_question_bank_view extends \core_question\local\bank\view {
 
     /**
      * Define the columns we want to be displayed on the question bank
-     * @return array
+     * @return array core_question\local\bank\view::$requiredcolumns which are to
+     *  be displayed.
      */
     protected function wanted_columns(): array {
         // Full class names for question bank columns.
@@ -64,8 +65,8 @@ protected function wanted_columns(): array {
 
     /**
      * Shows the question bank editing interface.
-     * @param string $tabname
-     * @param array $pagevars
+     * @param string $tabname question bank edit tab name
+     * @param array $pagevars list of page variables
      * @throws \coding_exception
      */
     public function display($pagevars, $tabname): void {

diff --git a/classes/exporter.php b/classes/exporter.php
@@ -158,8 +158,8 @@ public function export_attendance_csv(jazzquiz_session $session) {
             $idnumber = $attendance['idnumber'];
             $userFirstLastName = explode(', ', $attendance['name']);
             if (count($userFirstLastName) >= 2) {
-                $lastName = $userFirstLastName[0];
-                $firstName = $userFirstLastName[1];
+                $lastName = $userFirstLastName[1];
+                $firstName = $userFirstLastName[0];
             } else {
                 $lastName = $userFirstLastName[0];
                 $firstName = $userFirstLastName[0]; //for anonymous, but it doesn't even make sense since if it's anon, no name should display

diff --git a/edit.php b/edit.php
@@ -163,7 +163,7 @@ function jazzquiz_edit() {
         $pagevars) = question_edit_setup('editq', '/mod/jazzquiz/edit.php', true);
 
     $jazzquiz = new jazzquiz($cmid);
-    $renderer = $jazzquiz->renderer;
+    $renderer = $jazzquiz->renderer; // Todo: Flytt ned til hvor variabelen blir brukt
 
     $modulename = get_string('modulename', 'jazzquiz');
     $quizname = format_string($jazzquiz->data->name, true);
@@ -182,6 +182,7 @@ function jazzquiz_edit() {
 
     // Process moving, deleting and unhiding questions...
     $questionbank = new \core_question\local\bank\view($contexts, $url, $COURSE, $cm);
+
 
     switch ($action) {
         case 'order':