Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge request #97 #114

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Merge request #97 #114

merged 1 commit into from
Aug 7, 2023

Conversation

jorgenfinsveen
Copy link

Resolved issue by adding the question text column and implementing a function which determines whether to display the column or not in the question bank view

@jorgenfinsveen jorgenfinsveen linked an issue Jul 28, 2023 that may be closed by this pull request
@hgeorgsch
Copy link

The question question text column cannot be turned off, even if No is selected in the dropdown.

@jorgenfinsveen
Copy link
Author

@hgeorgsch that's odd. It works when I turn it off. When selecting "No" in the dropdown, only the question title is displayed. Tested it now:

Text with media

Skjermbilde 2023-08-07 kl  14 18 58

Only text

Skjermbilde 2023-08-07 kl  14 19 27

No text

Skjermbilde 2023-08-07 kl  14 20 05

@jorgenfinsveen
Copy link
Author

jorgenfinsveen commented Aug 7, 2023

Re-tested this now for Moodle version 4.1 and 4.3 using both Safari, Google Chrome, Mozilla Firefox, and Opera. Worked every time I tested

@hgeorgsch
Copy link

OK. Do you know if I need to do something to regenerate CSS files?
I saw some suspicious code suggesting that I had old CSS code.

@hgeorgsch
Copy link

Sorry. My fault. Got it now.

@hgeorgsch hgeorgsch merged commit 4178821 into develop Aug 7, 2023
0 of 26 checks passed
@sebastsg sebastsg deleted the bug/#97 branch April 20, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No question text in the question bank view
2 participants