Change radiatorHeadroom value to restore analytical propellant cooling functionality #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g functionality The 0.69 value was chosen to approximate the cooling performance of the radiators when they still had their old maxTemp = 1073.15 tags.
|
At timewarp speeds of 1e6 and 6e6 there still are some issues where cooling is insufficient, but that is probably a separate issue. |
|
Siimav has done some digging in the code. This is how the radiator headroom functions |
Update comments to indicate how radiatorHeadroom works Update mass of small radiator to match its calculated mass. Was too heavy previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR #2876 radiators have not been working correctly. They provide zero cooling performance during analytical timewarp. The lowered temperature tolerances of the part somehow negatively affect its cooling capabilities.
Increasing the value of the radiatorHeadroom tag restores them to their old cooling performance. I don't actually know how this value is used to calculate radiator performance and the comments in the file are not particularly enlightening. Therefore, the 0.69 value for radiatorHeadroom was chosen to approximate the cooling performance of the radiators when they still had their old maxTemp = 1073.15 tags.