-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github integration #33
Comments
To make this work the best, it should integrate as a webhook that gets notified every time a release is released. |
Only issue I can see is that Github doesn't have metadata for which KSP version is supported, so mod authors would need to update that on Spacedock afterwards. |
Pull data from a |
Where possible, sure. Mainly need to make sure that mod authors setting up the link are aware of the limitations/requirements/possibilities. |
@politas That is find, part of the GitHub integration would be to not publish the mod, so that the modder will have to publish it manually first thus updating the mod on SpaceDock afterwards. @jkoritzinsky I'm also not opposed to a version file if present. We'll need to flush the workflow out more |
Version info could just be pulled from the tag that is created while drafting a release on github, as most modders use this tag to denote version number anyway. |
Mod version number, yeah, but not supported KSP version. |
@politas That can be set during first time setup, i.g. where you create the mod page on spacedock itself. |
...Until a new version of KSP is released. |
...new version nearly released. :) |
In case any modders are interested, Nertea has done this on the GitHub side via the API: |
Fixing how this is put, that is all.
Adding github integration on the level of an author (who has linked the accounts) will only have to post a release to github, and the release be pulled to spacedock automatically as an update to the mod in question. Changelog and the like can be automatically filled out by pulled from changelog.md files as well. On page issue reporting (i.g. not having to go to the github page to post or review issues) can also be supported, though I don't recall how this is handled.
The text was updated successfully, but these errors were encountered: