New forum URLs, drop broken modules, delete OAuth #503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
On 2023-12-07, Rip Van SpaceDock awoke to discover the world changed around him. Formerly working and supported Python modules no longer loaded:
flask
no longer exportsMarkup
flask.json
no longer exportsJSONEncoder
flask_oauthlib.client
had a similar problem that I didn't capture, and all of the OAuth stuff wasn't being used anyway.This was hacked around by live-editing
lib/python3.10/site-packages/flaskext/markdown.py
in production 🤮.From the description, it sounds likely that this broke some part of the site that we don't know about yet.
Motivation
The KSP forum's user profile link format changed (
/index.php?
was dropped), so recently posted URLs aren't rendered as name-and-link as they are supposed to be.Changes
markdown
filter from the standard module instead of using Flask-Markdown. As a bonus, the underlying converter is now shared withcommon.render_markdown
(which previously didn't support emojis), so the format will now be reliably consistent.json.JSONEncoder
instead offlask.json.JSONEncoder
/dev/log
because this is OS-specific and was breaking on WindowsI'll probably just merge this to keep things moving along...