Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DESIGN] 디자인 시스템 세팅 #4

Merged
merged 8 commits into from
Apr 28, 2024
Merged

[DESIGN] 디자인 시스템 세팅 #4

merged 8 commits into from
Apr 28, 2024

Conversation

AAminha
Copy link
Member

@AAminha AAminha commented Apr 26, 2024 •
edited
Loading

1️⃣ 요약

2️⃣ 참고사항

  • 디자인 시스템에 radius도 만들어주시긴 하셨는데, 디자인 시스템까지 적용해야할지는 아직까지 잘 모르겠어서 일단 배제했습니다! 만약 radius가 많이 사용된다고 판단되면 추후에 추가하도록 하겠습니다.
  • SpoqaHanSansNeo 폰트가 불러오는 속도가 느려서 CDN 사용을 권장하고 있다는 포스트를 봤어요.
    저희는 그것까지 못하니까 FOIT, FOUT 현상을 최대한 줄일 수 있는 방안이 로컬로 사용하는 방법이라고 판단해 import 대신 다운로드를 받는 방식으로 택했습니다. (근거 있는 소리인지는 잘 모르겠어요..ㅎ)

3️⃣ 리뷰 요구사항

  • 생각보다 설정해야할 내용들이 많아 파일 분리를 진행했습니다. 괜찮은지 봐주세요!

AAminha added 4 commits April 25, 2024 17:01
@AAminha
design: 디자인 시스템 color 추가 (#2)
696089b
@AAminha
design: 디자인 시스템 typo 추가 (#2)
e6c4215
@AAminha
rename: style 관련 폴더 구조 변경 및 theme.ts 내부 요소 분리 (#2)
4d4f8f2 
- theme.ts에 있던 color와 font를 다른 파일로 분리
- global style 관련 파일을 `global` 폴더로 이동
- theme 관련 파일을 'theme' 폴더로 이동
@AAminha
design: 디자인 시스템 breakpoint 추가 (#2)
3a2eda2
@AAminha AAminha added the 🎨 Design 디자인 이슈 label Apr 26, 2024
@AAminha AAminha requested a review from mungjin01 April 26, 2024 05:42
@AAminha AAminha self-assigned this Apr 26, 2024
@AAminha AAminha force-pushed the design/#2/design-system branch from 1526119 to 203b571 Compare April 26, 2024 10:30
mungjin01
mungjin01 reviewed Apr 27, 2024
View reviewed changes
src/styles/theme/color.ts Outdated

// Secondary
secondary900: '#66273b',
secondary800: '86334e#',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 #86334e 로 바꿔주세요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호!!!!!! 찾아주셔서 감사합니다ㅎㅎ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 완료했습니당

mungjin01
mungjin01 reviewed Apr 27, 2024
View reviewed changes
src/styles/theme/color.ts
gray50: '#fbfbfb',

// etc
bgModal: 'rgba(18, 18, 18, 0.36)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 18 -> 12로 수정해주세요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인해봤는데 이건 틀린 게 없는 것 같아요..!

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인해봤는데 이건 틀린 게 없는 것 같아요..!

image

헉 그렇네요 수고하셨습니다!

mungjin01
mungjin01 reviewed Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@mungjin01 mungjin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@AAminha AAminha requested a review from mungjin01 April 27, 2024 15:55
@AAminha AAminha merged commit bd3825c into develop Apr 28, 2024
@AAminha AAminha deleted the design/#2/design-system branch April 28, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mungjin01 mungjin01 mungjin01 approved these changes

Assignees

@AAminha AAminha

Labels
🎨 Design 디자인 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DESIGN] 디자인 시스템 세팅
2 participants
@AAminha @mungjin01