Replace NA with "" in character columns

KWB-R · Nov 28, 2023 · 2396d3a · 2396d3a
1 parent e20aaa0
commit 2396d3a
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 3 deletions.
diff --git a/R/readAndMergeEuCodedFiles.R b/R/readAndMergeEuCodedFiles.R
@@ -86,10 +86,18 @@ mergeInspectionData <- function(x, warn = FALSE)
     obs
   })
 
+  header.info <- get_elements(x[[1L]], "header.info")
+  inspections <- kwb.utils::safeRowBindOfListElements(x, "inspections")
+  observations <- kwb.utils::safeRowBindAll(observations)
+
+  # Replace NA with "" in columns of type character
+  inspections <- replaceNaWithEmptyStringInCharColumns(inspections)
+  observations <- replaceNaWithEmptyStringInCharColumns(observations)
+
   list(
-    header.info = get_elements(x[[1L]], "header.info"), 
-    inspections = kwb.utils::safeRowBindOfListElements(x, "inspections"),
-    observations = kwb.utils::safeRowBindAll(observations)
+    header.info = header.info, 
+    inspections = inspections,
+    observations = observations
   )
 }
 

diff --git a/R/utils.R b/R/utils.R
@@ -119,6 +119,19 @@ removeEmptyLines <- function(x, dbg = TRUE)
   )
 }
 
+# replaceNaWithEmptyStringInCharColumns ----------------------------------------
+replaceNaWithEmptyStringInCharColumns <- function(x)
+{
+  is_char <- sapply(x, is.character)
+
+  x[is_char] <- lapply(x[is_char], function(y) {
+    y[is.na(y)] <- ""
+    y
+  })
+
+  x
+}
+
 # valuesToCsv ------------------------------------------------------------------
 
 #' Values to CSV

diff --git a/tests/testthat/test-function-replaceNaWithEmptyStringInCharColumns.R b/tests/testthat/test-function-replaceNaWithEmptyStringInCharColumns.R
@@ -0,0 +1,15 @@
+#library(testthat)
+test_that("replaceNaWithEmptyStringInCharColumns() works", {
+
+  f <- kwb.en13508.2:::replaceNaWithEmptyStringInCharColumns
+
+  expect_error(f())
+
+  x <- data.frame(
+    a = 1:2, 
+    b = c("x", NA)
+  )
+
+  expect_identical(f(x)[["b"]], c("x", ""))
+
+})