Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config: Disable naming-convention rule for non-js and non-ts files. #130

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

willdawsonme
Copy link
Contributor

Ran into an issue when updating to the latest version of eslint-config:

Error: Error while loading rule '@typescript-eslint/naming-convention': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.
Occurred while linting /Users/will/code/kablamo/os/os-frontend/packages/design-system/src/docs/Cheatsheet.mdx

@nhardy found that the naming-convention rule requires type information, so this rule should only be enabled on js and ts files.

@willdawsonme willdawsonme requested a review from nhardy November 21, 2023 01:23
@coveralls
Copy link

Coverage Status

coverage: 82.059%. remained the same
when pulling 709a628 on fix/eslint-config-naming-convention-move
into 376d757 on master.

@nhardy nhardy merged commit 057b748 into master Nov 21, 2023
4 checks passed
@nhardy nhardy deleted the fix/eslint-config-naming-convention-move branch November 21, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants