Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fixes incorrect token for box padding-xs #365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anechol
Copy link
Contributor

@anechol anechol commented Feb 7, 2025

Description

Fixes issue with <pds-box> padding-xs using incorrect token.

Before:
Screenshot 2025-02-07 at 1 28 19 PM

After:
Screenshot 2025-02-07 at 1 18 33 PM

DSS-1272

Type of change

  • Style (adds, updates, or removes component styling)

How Has This Been Tested?

Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@anechol anechol added the bug Something isn't working label Feb 7, 2025
@anechol anechol self-assigned this Feb 7, 2025
@github-actions github-actions bot added the package: core Changes have been made to the Core package label Feb 7, 2025
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for pine-design-system failed.

Name Link
🔨 Latest commit dcc205b
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/67a6622701a0d200083d6a4b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: core Changes have been made to the Core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant