style: update loader tokens to pine #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflips
commented
Feb 5, 2025
| } | ||
|
|
||
| &::before { | ||
| background-color: sage-color(primary, 300); | ||
| background-color: var(--pine-color-accent); |
There was a problem hiding this comment.
verified with design that this should become accent since primary does not exist as a pine semantic token
pixelflips
commented
Feb 5, 2025
| animation: loader-bar $-loader-bar-speed linear infinite; | ||
| } | ||
|
|
||
| &::after { | ||
| background-color: sage-color(primary, 300); | ||
| background-color: var(--pine-color-accent); |
There was a problem hiding this comment.
verified with design that this should become accent since primary does not exist as a pine semantic token
pixelflips
commented
Feb 5, 2025
| @@ -82,7 +82,7 @@ export const Loader = ({ | |||
| </svg> | |||
| )} | |||
| {(type === LOADER_TYPES.SUCCESS) && ( | |||
| <svg className="sage-loader__success" width="48" height="48" fill="none" xmlns="http://www.w3.org/2000/svg"><circle cx="24" cy="24" r="21" fill="#0072EF" /><path fillRule="evenodd" clipRule="evenodd" d="M34.707 17.293a1 1 0 0 1 0 1.414l-13 13a1 1 0 0 1-1.414 0l-7-7a1 1 0 0 1 1.414-1.414L21 29.586l12.293-12.293a1 1 0 0 1 1.414 0Z" fill="#fff" /></svg> | |||
| <svg className="sage-loader__success" width="48" height="48" fill="none" xmlns="http://www.w3.org/2000/svg"><circle cx="24" cy="24" r="21" fill="#6b62f2" /><path fillRule="evenodd" clipRule="evenodd" d="M34.707 17.293a1 1 0 0 1 0 1.414l-13 13a1 1 0 0 1-1.414 0l-7-7a1 1 0 0 1 1.414-1.414L21 29.586l12.293-12.293a1 1 0 0 1 1.414 0Z" fill="#fff" /></svg> | |||
There was a problem hiding this comment.
verified with design that this should become accent color in sage. there is no equivalent in pine.
pixelflips
commented
Feb 5, 2025
| @@ -37,7 +37,7 @@ | |||
|
|
|||
| <%# Success/Complete SVG %> | |||
| <% if component.type === "success" %> | |||
| <svg class="sage-loader__success" width="48" height="48" fill="none" xmlns="http://www.w3.org/2000/svg"><circle cx="24" cy="24" r="21" fill="#0072EF"/><path fill-rule="evenodd" clip-rule="evenodd" d="M34.707 17.293a1 1 0 0 1 0 1.414l-13 13a1 1 0 0 1-1.414 0l-7-7a1 1 0 0 1 1.414-1.414L21 29.586l12.293-12.293a1 1 0 0 1 1.414 0Z" fill="#fff"/></svg> | |||
| <svg class="sage-loader__success" width="48" height="48" fill="none" xmlns="http://www.w3.org/2000/svg"><circle cx="24" cy="24" r="21" fill="#6b62f2"/><path fill-rule="evenodd" clip-rule="evenodd" d="M34.707 17.293a1 1 0 0 1 0 1.414l-13 13a1 1 0 0 1-1.414 0l-7-7a1 1 0 0 1 1.414-1.414L21 29.586l12.293-12.293a1 1 0 0 1 1.414 0Z" fill="#fff"/></svg> | |||
There was a problem hiding this comment.
verified with design that this should become accent color in sage. there is no equivalent in pine.
anechol
approved these changes
Feb 7, 2025
@anechol done. great catch. |
QuintonJason
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts sage tokens to pine tokens
Testing in
sage-libNavigate to loader
Verify token updates
Testing in
kajabi-productsRelated
https://kajabi.atlassian.net/browse/DSS-1261