Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in small screens and refactor test (MacOS only) #80

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

SamuMazzi
Copy link
Contributor

No description provided.

@Kalmat
Copy link
Owner

Kalmat commented Oct 11, 2023

Thank you!

If I am not wrong, the position and size values are still the same than in previous version, right? Is the problem with small screens solved and, just curious, how?

@SamuMazzi
Copy link
Contributor Author

Exactly, I left the same values, I just refactored a bit. Regarding the problem I just moved the window before making it bigger, so that it could have enough space to get larger.

Also I wanted to say that this piece of code lowered = npw.lowerWindow() doesn't return the correct value (in the test it actually doesn't get lowered)
Maybe this isn't the right place to tell it, but I didn't want to forget that

@Kalmat
Copy link
Owner

Kalmat commented Oct 11, 2023

Ah, Ok! Sorry for not realizing...

I will take a look into lowerWindow() method, thank you for pointing it out! The problem is that there is no way to lower a window using Apple Script. I had to work on a sort of "hack", but perhaps it's not working as intended.

@Kalmat Kalmat merged commit 8337e37 into Kalmat:master Oct 11, 2023
4 checks passed
@Kalmat
Copy link
Owner

Kalmat commented Oct 11, 2023

By the way, the test_move() function is gorgeous! I didn't know that was even possible! You will never go to bed... without learning something new! HAHAHAHA!

I have adopted that solution for the rest of the OSs. Now all basic_* tests look the same.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants