Fix an issue with identical combined data store retrievals

Kampfkarren · Sep 2, 2019 · 56a0d27 · 56a0d27
1 parent 0896309
commit 56a0d27
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/DataStore2/init.lua b/DataStore2/init.lua
@@ -489,7 +489,7 @@ do
 		self.combinedInitialGot = true
 		tableResult[self.combinedName] = clone(tableValue)
 		self.combinedStore:Set(tableResult, true)
-		return tableValue
+		return clone(tableValue)
 	end
 
 	function CombinedDataStore:Set(value, dontCallOnUpdate)

diff --git a/Tests/tests/DataStore2.spec.lua b/Tests/tests/DataStore2.spec.lua
@@ -329,6 +329,12 @@ return function()
 				dataStore:Increment(1)
 				expect(called).to.equal(true)
 			end)
+
+			it("should not return an identical value for default values", function()
+				local dataStore = DataStore2(UUID(), fakePlayer)
+				local data = {}
+				expect(dataStore:Get(data)).to.never.equal(data)
+			end)
 		end
 	end