Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨feat: .selene.toml and selene.toml are now detected by order of priority #591

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open
Changes from 2 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6ad27f6
✨feat: `selene.toml` and `.selene.toml` are not detected by order of …
Zeioth Mar 10, 2024
02213f4
🐛fix(`.selene`): has now order of precedence over `selene.toml`.
Zeioth Mar 13, 2024
b4a93e3
🐛fix(error!): instead of eprintln.
Zeioth Mar 13, 2024
13e6286
♻️refactor(read_config_file): Is now a function.
Zeioth Mar 13, 2024
9e91ded
Update selene/src/main.rs
Zeioth Mar 15, 2024
de9aa79
fix: Terminate the process when config file is invalid.
Zeioth Mar 17, 2024
8947dea
fix: We now check that the file exist. Also we only raise a error if …
Zeioth Mar 18, 2024
406558f
fix(regression): Ensure it fallback on the default config.
Zeioth Mar 18, 2024
f7785fb
refactor of the former
Zeioth Mar 18, 2024
5def22b
♻️refactor: All should be fine now, but we can still refactor the fun…
Zeioth Mar 18, 2024
69d6d98
♻️refactor: All config file detection logic has been moved to functions.
Zeioth Mar 18, 2024
64bbb82
comments: More consistent.
Zeioth Mar 18, 2024
d0cb38e
Update CHANGELOG.md
Zeioth Mar 18, 2024
e5fd4f0
docs: updated for `.selene.toml`.
Zeioth Mar 18, 2024
d7de32e
Merge remote-tracking branch 'refs/remotes/origin/dot-selene-toml'
Zeioth Mar 18, 2024
1c425b8
fix(comments): Our comments were preventing `cargo rustdoc` from runn…
Zeioth Mar 18, 2024
0ef6e80
Update selene/src/main.rs
Zeioth Mar 26, 2024
ef996c4
Update selene/src/main.rs
Zeioth Mar 26, 2024
822bc44
refactor: config_paths_to_check is now a constant.
Zeioth Mar 26, 2024
ade463c
refactor: read_config_file() -> (String, Option<PathBuf>) the type re…
Zeioth Mar 27, 2024
3812d6b
refactor: Now that we handle the bad utf-8 error correctly, let's add…
Zeioth Mar 27, 2024
47b0642
vscode: relevant changes to vscode extension.
Zeioth Mar 27, 2024
4ca19d4
♻️refactor: We now let rust manage the invalid UTF-8 error instead of…
Zeioth May 7, 2024
aff6f9a
🐛fix(config file detection): If path exists and fs::read_to_string er…
Zeioth May 8, 2024
7c844a3
🐛refactor: There is no need for us to explicitely read the file as ut…
Zeioth May 8, 2024
5c02fe9
comments: Better info, in case we decide to enable this.
Zeioth May 8, 2024
9829822
fix: The error now works as originally intended → `ERROR: Error readi…
Zeioth May 21, 2024
ed5e764
Update main.rs → comments
Zeioth May 21, 2024
7fa7825
fix: Display the next error ONLY on validate-config → `ERROR: Error r…
Zeioth May 21, 2024
8817d13
Solve merge conflict
Zeioth May 21, 2024
04ed488
Merge branch 'main' into dot-selene-toml
chriscerie Jun 29, 2024
dcf3458
Refactor
chriscerie Jun 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
## [Unreleased](https://github.com/Kampfkarren/selene/compare/0.26.1...HEAD)
### Added
- Added `CFrame.lookAlong` to the Roblox standard library
- Added `.selene.toml` as possible config file, with priority over `selene.toml`.

### Changed
- Updated the warning message for the `mixed_table` lint to include why mixed tables should be avoided
@@ -427,4 +428,4 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Added standard library chaining. This means you can combine two standard libraries by setting `std` in selene.toml to `std1+std2`. You can chain as many as you want.

## [0.1.0](https://github.com/Kampfkarren/selene/releases/tag/0.1.0) - 2019-11-06
- Initial release
- Initial release