Skip to content

Commit

Permalink
fix: filters should not be included in viewDims/viewMeas (#130)
Browse files Browse the repository at this point in the history
  • Loading branch information
k6sdevbob authored Aug 4, 2023
1 parent f46c0d7 commit a325ce0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/graphic-walker/src/store/visualSpecStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export class VizSpecStore {
*/
public get viewDimensions(): IViewField[] {
const { draggableFieldState } = this;
const state = toJS(draggableFieldState);
const { filters, ...state } = toJS(draggableFieldState);
const fields: IViewField[] = [];
(Object.keys(state) as (keyof DraggableFieldState)[])
.filter((dkey) => !MetaFieldKeys.includes(dkey))
Expand All @@ -278,7 +278,7 @@ export class VizSpecStore {
*/
public get viewMeasures(): IViewField[] {
const { draggableFieldState } = this;
const state = toJS(draggableFieldState);
const { filters, ...state } = toJS(draggableFieldState);
const fields: IViewField[] = [];
(Object.keys(state) as (keyof DraggableFieldState)[])
.filter((dkey) => !MetaFieldKeys.includes(dkey))
Expand Down

1 comment on commit a325ce0

@vercel
Copy link

@vercel vercel bot commented on a325ce0 Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.