Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend image-stats tag endpoint to filter by image name #34

Closed
wants to merge 1 commit into from

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Jun 14, 2024

I was looking for a way to get data only for a specific test from a specific tag (and at a later I would like to add date-based filters (my goal is to be able to get only newer entries than I have already fetched).

I considered creating a new endpoint but this doesn't seem to scale well, so I thought we could start extending some of our existing endpoints instead, so here is a draft for this.

The reason I opened this as a draft is because I am toying with the idea of extending the base endpoint api/v1/image-stats with query params to filter the data according to various options.

@Karm @jerboaa WDYT is the best way to go?

Note: This is related to Hyperfoil/Horreum#1703

@zakkak
Copy link
Collaborator Author

zakkak commented Jul 4, 2024

@jerboaa @Karm could you please have a look and give me some feedback?

@jerboaa
Copy link
Collaborator

jerboaa commented Jul 4, 2024

@zakkak It seems the default GET entry point ought to get amended with a variety of query params. That would be a better fit than the get-all-by-tag entry point. The default, if there is no query param, it would return all stats as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants