This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
fix memory leak #186
Closed
fix memory leak #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lzdon , Travis CI is failing for your PR. Before accepting any change we need that check to be passed. |
|
Could we get some movement on this? The memory leak is real. |
|
Please, refer to https://github.com/Karumi/Dexter#do-you-want-to-contribute |
|
Yup, I totally get it. I guess I was hoping the original contributor would take another stab at it. I'm honestly not even sure his PR fixes the problem... looks a bit like a stab in the dark, but I guess it might work 🤷♂️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i found there is memory leak when permissions are granted. i read the code , found that the field 'listener' not released ,is there some sepcial reason?