Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Fix token bypassed in base listeners #205

Closed
wants to merge 1 commit into from

Conversation

Camerash
Copy link

What's in this PR?

@Camerash
Copy link
Author

I have considered adding a bypassRationale flag in builders of the listeners to decide whether or not to consume the token in the respective listener, since people seems to forget consuming the token and lead to permission granting came to a halt. Don't know if it is better this way though 🤔

@Serchinastico
Copy link
Contributor

Hi @Camerash, we can't really apply these changes to fix #184. The issue is in the sample project, not the base listeners implementation, we can't change that without breaking backwards compatibility and there is a strong reason we are calling the token in the base listeners, that is, we had a lot of reports of people not understanding they had to call the token to continue the process.

Thank you for your contribution, though

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants