feat: add check to ensure no module is named base

KashunCheng · Mar 30, 2023 · 349e368 · 349e368
1 parent eb2940f
commit 349e368
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/transpire/internal/cli/obj.py b/transpire/internal/cli/obj.py
@@ -34,7 +34,6 @@ def build(out_path, **_) -> None:
         logger.info(f"Building {module.name}")
         render.write_manifests(config, module.objects, module.name, out_path)
 
-    # TODO: Disallow calling a transpire module "base", via Pydantic.
     logger.info("Writing bases")
     basedir = Path(out_path) / "base"
     if basedir.exists():

diff --git a/transpire/types.py b/transpire/types.py
@@ -49,7 +49,9 @@ def __init__(self, pymodule: ModuleType, context=None):
 
     @property
     def name(self) -> str:
-        return self.pymodule.name
+        name = self.pymodule.name
+        assert name != "base"
+        return name
 
     @cached_property
     def namespace(self) -> str: