Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for port to python 3 #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

HendJordan
Copy link

Changed join in send.py to perform the join for byte objects instead of
strings.
Replaced xrange with range in quitnet.py because xrange was
removed in python 3.
Added Queue.py module to repo because this library
does not exist in python 3, so that import was failing.

changed join in send.py to perform the join for byte objects instead of
strings, changed xrange to range in quitnet.py because xrange was
removed in python 3. Added Queue.py module to repo because this library
does not exist in python 3.
@lrq3000
Copy link

lrq3000 commented Mar 14, 2020

For Queue, simply change the import to this in Python 3:

try:
    # Python 2
    import Queue
except ModuleNotFoundError:
    # Python 3
    import queue as Queue

@lrq3000
Copy link

lrq3000 commented Mar 14, 2020

Also I can confirm that I did similar changes and the library works

@kpcyrd
Copy link

kpcyrd commented Mar 14, 2020

I'd recommend to just use import queue as Queue since python2 is end of life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants