Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37859 - Re-drop evr extension in katello #11159

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Sep 24, 2024

What are the changes introduced in this pull request?

This brings back the changes from #11087 which were reverted as part of #11103 to stop blocking 4.14.

Considerations taken when implementing this change?

Also pulled in some updates from #11098 which came out of additional reviews on the first katello PR.

What are the testing steps for this pull request?

Same as testing steps for #11087
Check sudo rpm -qa evr
Remove the rpm: sudo rpm -e evr_package_from_above
Run bundle exec rails katello:reset to mimic fresh installs
Test the usual flows with applicability
To test existing systems just delete the evr package and make sure everything continues to work as normal.

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working fine still! I think it's safe to merge even now, yeah? We could also wait until we learn more about how remote databases will deal with the changes, up to you. Worst case we have another revert (but I really hope not!)

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding an error if the permissions aren't sufficient?

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I don't think my previous comment is important anymore, ACK

@sjha4 sjha4 merged commit a153d94 into Katello:master Dec 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants