Show Accepted Submission Score; Avoid Parsing HTML #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you're at it, is it possible to include |
hairez
reviewed
Aug 18, 2024
| @@ -370,12 +366,7 @@ def show_judgement(submission_url, cfg): | |||
| success = status_id == _ACCEPTED_STATUS | |||
| if success: | |||
| status_text += f' ({score})' | |||
There was a problem hiding this comment.
Something like
if success:
status_text += f' ({score}/{maxscore})'would be nice.
Is it possible to include the maxscore information from Kattis?
There was a problem hiding this comment.
Unfortunately, there's no maxscore information available from/in Kattis, so there's no way to correctly show that (without making assumptions, which could be incorrect...)
JoelNiemela
force-pushed
the
print-submission-score
branch
from
4228e8f
to
6a9a351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
This also removes
lxmlas a dependency.This requires the Kattis
/submissions/<id>?jsonendpoint to add some more fields:score,runtime,testcase_count, andcompiler_feedbackBefore merging this, the required Kattis changes need to be done first, and this needs to be properly tested.